Pros
Joob security is pretty good. You know you will always be paid on time. The free medical is great. You will go places and see things you might not otherwise. Most people like to see you in uniform. People tend to think you are trustworthy. Free housing. 30 days paid vacation every year along with most Federal Holidays off (Depending on your job). Don't have to worry about what outfits you will wear to work all week. I can get my clothes dirty without ruining them. Yearly pay raises and two raises every other year. Meet a lot of good people. Military discounts in many places. I can draw an Army pension while I am still young enough to get a higher paying job elsewhere. I get paid waaaaaaay better than a lot of people I know with college degrees and If I had a degree, I would get paid more than that. I have bigger and better equipment to shoot back at people who shoot at me.
Cons
My travel agent kinda stinks. Its kinda dangerous at times. I joined to protect the United States not Iraq, Afghanistan, Bosnia, Dick Cheney's Bank Account, or George W.'s ego. I am trained as a blunt instrument of destruction and meyhem so trying to "POLICE" the world is a slightly awkward task. I wish the people I swore to protect would protect me from dumb leaders by voting better.